fix: Generate invoice for paid instant charges on subscription termination #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation Currently if an invoice with pay in advance charges is terminated, there are edgecases were paid fees are not invoiced because of a boundaries issues. This change ensure all paid fees not already invoiced are included in an invoice when the subscription is terminating ignoring boundaries.
lovrocolic
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently if an invoice with paid in advance charges is terminated, there are edge cases where paid fees are not invoiced because of a time boundaries issues.
Description
This change ensure all not already invoiced paid fees are included in a new invoice when the subscription is terminating ignoring time boundaries.